Skip to content

Traduction de library/zoneinfo.po #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2022
Merged

Traduction de library/zoneinfo.po #1879

merged 5 commits into from
May 27, 2022

Conversation

jeanas
Copy link
Collaborator

@jeanas jeanas commented May 21, 2022

Reprise de #1579

Closes #1532

Gaasmann
Gaasmann previously approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@Gaasmann Gaasmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR revue, rien à redire. J'approuve mais je ne suis pas sur d'avoir voix au chapitre en la matière :-)

@PyDocTeur
Copy link

Rajoutez-moi un automerge et ca part en prod !

Disclaimer

Je suis un robot fait par l'équipe de l'AFPy et de Traduction
sur leur temps libre. Je risque de dire des bétises. Ne me blâmez pas, blamez les développeurs.

Code source

I'm a bot made by the Translation and AFPy teams on their free
time. I might say or do dumb things sometimes. Don't blame me, blame the developer !

Source code

(state: approved)
PyDocTeur v1.12.0

@jeanas
Copy link
Collaborator Author

jeanas commented May 22, 2022

Non, toutes les relectures sont utiles ! La tienne ne débloque pas la fusion de la PR (seules les relectures de personnes avec les droits d'accès le font), mais cela n'empêche pas de faire des remarques pertinentes, et même si tu n'as rien à redire, le fait de manifester ton approbation permet d'avoir une idée du niveau de relecture qu'a reçu la PR.

christopheNan
christopheNan suggested changes May 24, 2022
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je mettrais au présent les descriptions qui ne font pas référence explicitement à un événement futur, comme préconisé dans CONTRIBUTING.

jeanas
jeanas commented May 24, 2022
View reviewed changes
@jeanas @christopheNan
Suggestions de Christophe + futurs
2f0b8cc 
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
christopheNan
christopheNan approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Merci !

@christopheNan christopheNan merged commit 1e8e99b into python:3.10 May 27, 2022
@jeanas jeanas deleted the zoneinfo branch May 27, 2022 08:51
JulienPalard pushed a commit that referenced this pull request Sep 13, 2022
@jeanas @christopheNan
@alkimya @JulienPalard
Traduction de library/zoneinfo.po (#1879)
aa14b26 
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-authored-by: Loc Cosnier <loc.cosnier@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopheNan christopheNan christopheNan approved these changes

@Gaasmann Gaasmann Gaasmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Je travaille sur library/zoneinfo.po

5 participants

@jeanas @PyDocTeur @Gaasmann @christopheNan @alkimya